Fix ShaderDebugInfo having invalid line numbers in 1.0#4189
Merged
arcady-lunarg merged 1 commit intoKhronosGroup:mainfrom Mar 24, 2026
Merged
Conversation
|
|
arcady-lunarg
requested changes
Mar 19, 2026
Contributor
arcady-lunarg
left a comment
arcady-lunarg
left a comment
There was a problem hiding this comment.
One minor test detail that should be fixed, otherwise lgtm
| 20: String "inued. | ||
| // This is filler text to cause the source length to exceed the maximum length of DebugSource and require the use of DebugSourceContinued. | ||
| // This is filler text to cause the source length to exceed the maximum length of DebugSource and require the use of DebugSourceContinued. | ||
| // This is filler text to cause the source length to exceed the maximum length of DebugSource " |
Contributor
There was a problem hiding this comment.
Could you add another copy of the filler comment to the test file to maintain the structure of the test with two DebugSourceContinueds?
Contributor
Author
There was a problem hiding this comment.
think I got it as best as it will get
Contributor
There was a problem hiding this comment.
Yeah that's fine, I just wanted the same number of instructions in the SPIR-V result.
spencer-lunarg
force-pushed
the
spencer-lunarg-fix-debuginfo
branch
from
7e705af to
1485048
Compare
arcady-lunarg
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3863
This is needed in order to have valid SPIR-V once I drop KhronosGroup/SPIRV-Tools#5986 in
spirv-val